Nicolas Solerieu

Results 19 comments of Nicolas Solerieu

@rezrah I agree with most of your suggestions, here are some additional specs considering the [pointers form a11y](https://github.slack.com/archives/C03RM57QL64/p1722279183774179?thread_ts=1722273398.961059&cid=C03RM57QL64) @natalie-iv gathered - Use numbers (not symbols) - Provide a back link...

Documentation notes: ### Default use: For a basic context agnostic use-case (legal disclaimer, sources, references), Footnotes should live before the footer ### Accessibility recommendation: To limit cognitive requirement, we recommended...

Due to PMM feedback and update no need to upstream this component yet until it’s been tested.- [Full doc here](https://docs.google.com/document/d/1xZJWAJcgyhX5wCSigVivFd6JYMG-DS-Lou2rjGZSkcA/edit) @simurai static build will provide the opportunity to test assumptions...

PRs are open: - Paragraphs: https://github.com/primer/doctocat/pull/705 - Headings: https://github.com/primer/doctocat/pull/706

I'm supportive of aligning with the BreakoutBanner to have default/subtle via `backgroundColor` prop

@joshfarrant I'm also in favor to bring parity between `CTABanner` and `BreakoutBanner` background options

Closing following decision explained here: https://github.com/github/primer/issues/4783#issuecomment-2730347695

I caught up with @simurai that is building the new feature pages where he has been using image backgrounds for the CTA Banners We'd love to have a background component...

+1 to all of @stamat points: - We dont have standard play/pause icon and I'm in favor of using @jesussandreas version for now as they have been adopted on a...