earthaccess icon indicating copy to clipboard operation
earthaccess copied to clipboard

Published 20 hours ago • verified publisher icon nsidc

"Soften" contributor requirements like unit tests

Open mfisher87 opened this issue 10 months ago • 4 comments

Some contributing requirements may be intimidating users from contributing. Let's change our language in the contributing guide to indicate:

If you're not comfortable writing unit tests, we still welcome your contribution! Just please ask for help and someone from the community will do their best to work with you.

mfisher87 avatar Apr 16 '24 19:04 mfisher87

As long as we don't merge any bug fixes/features without tests I'm OK with that.

doug-newman-nasa avatar Apr 16 '24 20:04 doug-newman-nasa

Yeah, I like saying it's okay to let PR CI/CD run the unit tests instead of needing to do it locally and it's okay to ask for help to make them pass

jhkennedy avatar Apr 16 '24 21:04 jhkennedy

As long as we don't merge any bug fixes/features without tests I'm OK with that.

:100:

mfisher87 avatar Apr 16 '24 22:04 mfisher87

I think a PR template is a good way to communicate the exact checklist in an accessible way, including the "ask for help" part. Then we can shorten the contributing doc a bit by linking to the PR checklist.

mfisher87 avatar Apr 17 '24 17:04 mfisher87