earthaccess icon indicating copy to clipboard operation
earthaccess copied to clipboard

Add ASDC collections to test suite

Open danielfromearth opened this issue 1 year ago • 5 comments

Add ASDC provider to tests, e.g., where ASDC collections are not currently listed: https://github.com/nsidc/earthaccess/blob/14c4fbeb8f4d27bf9145b558684f7b501214de78/tests/integration/test_cloud_download.py#L15

danielfromearth avatar Feb 16 '24 03:02 danielfromearth

@danielfromearth Are you still interested in adding ASDC collections? Not sure if this has already been tackled since you wrote the ticket.

asteiker avatar Sep 30 '25 16:09 asteiker

Yes, I'd still like to add ASDC to some of the tests, where ASDC collections are not currently listed, e.g., https://github.com/nsidc/earthaccess/blob/14c4fbeb8f4d27bf9145b558684f7b501214de78/tests/integration/test_cloud_download.py#L15

danielfromearth avatar Oct 08 '25 14:10 danielfromearth

Thanks for confirming @danielfromearth ! If it only requires an additional dictionary for ASDC, would the good first issue label apply here? I also wonder if we should be adding all providers to this list, or is there a reason we just have a manually curated list?

asteiker avatar Oct 08 '25 15:10 asteiker

@asteiker - I wonder if there's a way to programmatically get a list of providers, but maybe that could be a different issue? And in the meantime, I simply add ASDC as a provider to these dictionaries? Oh, and sure, the good-first-issue could apply, fine with me!

danielfromearth avatar Oct 08 '25 19:10 danielfromearth

@danielfromearth Thanks for your feedback! Agreed - I don't want to expand the scope of this issue. It just got me thinking about how we should approach the testing in general. Creating another issue is a good idea.

asteiker avatar Oct 08 '25 23:10 asteiker