mikrotik-exporter icon indicating copy to clipboard operation
mikrotik-exporter copied to clipboard

Published 20 hours ago • verified publisher icon nshttpd

Repository maintenance

Open Bluebugs opened this issue 1 year ago • 4 comments

There hasn't been much activity in the past 2 years. I can see that one difficulty in accepting pr is that there is no tests. Will it help unlock this if integration tests using testcontainer-go and docker routeros image where provided along with github action and coverage report?

Bluebugs avatar Mar 02 '24 05:03 Bluebugs

@nshttpd

imclint21 avatar May 03 '24 11:05 imclint21

I've got a fork over at https://github.com/ananthb/mikrotik-exporter mainly because I need arm container images. The multi-platform manifest container image is available now at https://ghcr.io/ananthb/mikrotik-exporter.

Time permitting, I'm planning on maintaining my fork too.

Still open to working with @nshttpd though.

ananthb avatar Jun 25 '24 13:06 ananthb

@ananthb If you plan to maintain your fork, it would be good to clarify how to open PR and issue. I am still interested to add a testcontainer-go coverage for this project along with CI to make it easier to do maintenance (updating dependencies) and make it easier to accept new PR by having a good code coverage and tests against a real mikrotik service as much as possible.

Bluebugs avatar Jul 10 '24 03:07 Bluebugs

You can now create issues @Bluebugs.

I've added basic automation on GitHub Actions already. I'd love to extend that with comprehensive tests.

ananthb avatar Jul 10 '24 08:07 ananthb