LOLA icon indicating copy to clipboard operation
LOLA copied to clipboard

PEP loading function for LOLA

Open joseverdezoto opened this issue 5 years ago • 4 comments

joseverdezoto avatar Dec 04 '19 17:12 joseverdezoto

@joseverdezoto this is not passing the travis unit tests, can you look into that?

nsheff avatar Jan 06 '20 19:01 nsheff

@nsheff could you look over the changes to the loadPEPdb function? I think the previous travis unit tests warnings arose because I didn't have simplecache installed locally. It could also be that warnings were being treated as errors. Let me know if the current changes look good.

joseverdezoto avatar Feb 20 '20 15:02 joseverdezoto

I think the previous travis unit tests warnings arose because I didn't have simplecache installed locally

this was running on travis, right? your local environment would be irrelevant...

nsheff avatar Feb 21 '20 14:02 nsheff

@nsheff I made the suggested changes tested the function. The only thing I'm not sure of is how we'd include pepr as a dependency. I tried updating the DESCRIPTION file but that commit didn't pass the travis unit tests because pepr could not be installed

joseverdezoto avatar Feb 21 '20 18:02 joseverdezoto