tikzplotlib icon indicating copy to clipboard operation
tikzplotlib copied to clipboard

Require matplotlib < 3.8 for `pgf.common_texification`

Open JasonGross opened this issue 1 year ago • 4 comments

As per https://github.com/nschloe/tikzplotlib/issues/559

JasonGross avatar Feb 28 '24 02:02 JasonGross

Wouldn'it it be nicer to have an actual fix instead?

FriedrichFroebel avatar Feb 28 '24 05:02 FriedrichFroebel

It would, but I don't have time to prepare an actual fix right now, and this is an easy patch to revert when a fix lands, and I don't think breaking pip's solver on this package while we wait for a fix(/wait to find time to fix it) is a good idea. Note that I didn't mark this PR as fixing the corresponding issue, and I don't think it makes sense to close that issue until a proper fix lands.

JasonGross avatar Feb 28 '24 06:02 JasonGross

Wouldn'it it be nicer to have an actual fix instead?

It seems there are a bunch of fixes for this in the wild that have not been turned into PRs, e.g., https://github.com/RobertDeibel/tikzplotlib/pull/2, https://github.com/lukashof/tikzplotlib/commit/9eddaba9d078375ebb1c65e652b460675de23b74, https://github.com/lucaslrodri/tikzplotlib/commit/860e4a5402b8f0041dabe87a1abaa01220cfb93a

JasonGross avatar Apr 03 '24 10:04 JasonGross

I created a PR #602. But I think it's been a while since something got merged, unfortunately.

lukashof avatar Apr 03 '24 13:04 lukashof