Nico Schlömer

factor 1/nu in K_p

1

[The documentation](https://fenapack.readthedocs.io/en/latest/index.html#math-background) says that the operator  is approximated by  It's not immediately obvious why there should be a factor `1 / nu` in `K_p`. Is this correct? If...

With PurePNG it's possible to generate a PNG from a row iterator. This is nice, because my data is way to large to fit into memory; with PNG compression it's...

access to PRIVATE, PUBLIC keywords on TARGET_LINK_LIBRARIES

8

After the CMake requirement will have been increased to 2.8.11, I would like to have access to the `LINK_PRIVATE`/`LINK_PUBLIC` arguments of [target_link_libraries()](http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:target_link_libraries) (or just `PRIVATE`/`PUBLIC`, as there where renamed in...

version checking for TPLs

4

Most packages not only depend on a TPL, but a certain version or version range thereof. TriBITS needs to support version checking and specification for TPLs.

escape CMake control characters in strings

2

Certain strings are copied literally from the input configuration to the export files. This has brought problems before where the `CXX_FLAGS` variable contained `"`, see [Trilinos bug #6074](https://software.sandia.gov/bugzilla/show_bug.cgi?id=6074) and the...

`INCLUDE()`s without proper path specification

9

TriBITS contains heaps of `INCLUDE()` statements ``` $ grep -r "INCLUDE(" package_arch/ | wc -l 256 ``` referencing its own files à la ``` INCLUDE(TribitsAddAdvancedTest) ``` The directories in which...

[snapshot-dir.py] Check if dest-dir is indeed a TriBITS installation

1

We can probably improve the snapshotter a little bit. One of the things missing is a check if dest-dir is indeed a TriBITS installation, which makes it harder to shoot...

[export files] *_PACKAGE_LIST, *_LIBRARIES too long

6

The export files are way to verbose on the `*_LIBRARIES` and `*_PACKAGE_LIST`. In Trilinos's NOX, for example we find ``` SET(NOX_LIBRARIES "trilinos_locathyra;trilinos_locaepetra;trilinos_localapack;trilinos_loca;trilinos_noxepetra;trilinos_noxlapack;trilinos_nox;trilinos_teko;trilinos_stratimikos;trilinos_stratimikosbelos;trilinos_stratimikosaztecoo;trilinos_stratimikosamesos;trilinos_stratimikosml;trilinos_stratimikosifpack;trilinos_ifpack2-adapters;trilinos_ifpack2;trilinos_zoltan2;trilinos_anasazitpetra;trilinos_ModeLaplace;trilinos_anasaziepetra;trilinos_anasazi;trilinos_belostpetra;trilinos_belosepetra;trilinos_belos;trilinos_ml;trilinos_ifpack;trilinos_amesos;trilinos_amesos2;trilinos_galeri-xpetra;trilinos_galeri;trilinos_aztecoo;trilinos_isorropia;trilinos_thyratpetra;trilinos_thyraepetraext;trilinos_thyraepetra;trilinos_thyracore;trilinos_xpetra-sup;trilinos_xpetra-ext;trilinos_xpetra;trilinos_epetraext;trilinos_tpetrarti;trilinos_tpetraext;trilinos_tpetrainout;trilinos_tpetra;trilinos_triutils;trilinos_zoltan;trilinos_epetra;trilinos_kokkosdisttsqr;trilinos_kokkosnodetsqr;trilinos_kokkoslinalg;trilinos_kokkosnodeapi;trilinos_kokkos;trilinos_rtop;trilinos_tpi;trilinos_teuchosremainder;trilinos_teuchosnumerics;trilinos_teuchoscomm;trilinos_teuchosparameterlist;trilinos_teuchoscore") ``` and ``` SET(NOX_PACKAGE_LIST "NOX;Teko;Stratimikos;Ifpack2;Zoltan2;Anasazi;Belos;BelosTpetra;BelosEpetra;BelosCore;ML;Ifpack;Amesos;Amesos2;Galeri;AztecOO;Isorropia;Thyra;ThyraTpetraAdapters;ThyraEpetraExtAdapters;ThyraEpetraAdapters;ThyraCore;Xpetra;EpetraExt;Tpetra;Triutils;Zoltan;Epetra;KokkosClassic;RTOp;ThreadPool;Teuchos;TeuchosRemainder;TeuchosNumerics;TeuchosComm;TeuchosParameterList;TeuchosCore") ``` These are...

Turn on -Wl,--no-undefined by default in development mode

14

The checkin-test script by default currently runs one `MPI_DEBUG` and one `SERIAL_RELEASE` build. I suppose the MPI/SERIAL DEBUG/RELEASE crossover this to cover as much of the code as possible. One...

Bring back default FIND_PACKAGE() for BLAS and LAPACK FindTPL<TPLNAME>.cmake modules

4

Reverted by Sandia bug https://software.sandia.gov/bugzilla/show_bug.cgi?id=6452.