HIRS icon indicating copy to clipboard operation
HIRS copied to clipboard

Check for null required fields when creating base RIMs

Open chubtub opened this issue 2 years ago • 2 comments

Remarks from user testing: I have tested removing "platformManufacturerStr" from the json config file, removing both "platformManufacturerStr" and "platformManufacturerId", as well as testing changing "platformManufacturerStr": "DellInc." to "platformManufacturerStr": "". The Base Rim will still be created in these cases.

In each of the mentioned cases the RIM creation should fail.

chubtub avatar Apr 04 '22 15:04 chubtub

This issue falls under #463

chubtub avatar Apr 04 '22 17:04 chubtub

-The json config file is invalid. Removed a comma from the json config file; I receive an error message: "Invalid token=STRING at (line no=7, column no=9, offset=143). Expected tokens are: [COMMA]" A Base Rim is created with the invalid file.

-The Model is missing from the json config file. Removed the entire "platformModel": from the json config file ; I don't receive an error message A Base Rim is created with the invalid file.

-The Payload Hash is missing from the json config file. Removed the "hash": "4479ca722623f8c47b703996ced3cbd981b06b1ae8a897db70137e0b7c546848" from the json config file ; I receive an error message: "Invalid token=CURLYCLOSE at (line no=37, column no=4, offset=922). Expected tokens are: [STRING]" A Base Rim is created with the invalid file.

-The SoftwareIdentity element is missing from the json config file. Removed the entire SoftwareIdentity element from the json config file ; I receive an error message: "null" A Base Rim is created with the invalid file.

chubtub avatar Apr 04 '22 21:04 chubtub