ns1-go icon indicating copy to clipboard operation
ns1-go copied to clipboard

Zone record json struct tag inconsistent casing

Open Ivan-Z opened this issue 3 years ago • 1 comments

For the domain property on the zone record struct, why is the JSON tag capitalized? https://github.com/ns1/ns1-go/blob/v2/rest/model/dns/zone.go#L59 It is inconsistent with the rest of the code base, and breaks some code-gen tools when trying to integrate with the ns1-go package.

Ivan-Z avatar Aug 24 '21 14:08 Ivan-Z

@Ivan-Z Thank you for reporting this issue. We already added this to our backlog.

ThiagoYU avatar Sep 21 '21 18:09 ThiagoYU

Hi Ivan, it's definitely inconsistent and not ideal, but changing it might cause trouble for anyone with code that uses marshal/unmarshal on that struct.

Can you give us more details on the code-gen tools that were having trouble integrating with ns1-go? Were you able to find workarounds?

eravin-ns1 avatar Dec 14 '22 20:12 eravin-ns1

This fix will go out with the next version bump

jfarrell-NS1 avatar Apr 26 '23 16:04 jfarrell-NS1