Nicolas Rybowski

Results 50 comments of Nicolas Rybowski

The force push is a rebase on 8ad0dd112a85a9021354deffb70d43c58ec577c7 and the cleanup of some commit messages. I still have to enforce the constraints on the acceptable values for the BIER configuration...

980694896ed393dc66ea4b8b53bd9dcdaa247f1d is the commit on [`bier-rebased`](https://github.com/holo-routing/holo/tree/bier-rebased) that includes the addition of the YANG model for BIER on top of the latest commit on master (08dcc23). The PR should be ready...

Rebased on ad7ab7214eff7094c39d6c445b24786f090221df.

The development of the new documentation will now [take place on this branch](https://github.com/INGInious/INGInious/tree/docv2). [The progress is still tracked by a specific milestone](https://github.com/INGInious/INGInious/milestone/11).

I saw that https://github.com/holo-routing/holo/commit/a2be4c92d4aaf91f33fcf218b7257bf92705e584#diff-5246d5827a28289713a7a2862650266d88b0fb20e7d0f3e76d1c291194ccc9bf already contains some boilerplate to include `ietf-igmp-mld` and some related YANG modules. Maybe we could extract this addition in a separate commit so that we can...

@rwestphal Thanks for the update! I will rebase on master and continue the implementation from there.

Thanks for this first review! > Also, the "enable-advertise" leaf can be removed, as the presence of "metric" already implies we want to advertise the reverse metric. This was also...

Just rebased on [master](https://github.com/holo-routing/holo/commit/49a2d4ebde079164a872784c212071101a993797) to clear the conflicts. https://github.com/holo-routing/holo/pull/78/commits/81df85f61627aa0f60524e0323a88ab17984b1ec contains the changes we just discussed. > Just keep in mind that in "interface/topologies/topology" you can configure a topology name, but...

Thanks for the report. I would rather extend the `docker-compose.yml` file to build locally the [default grading environment](https://github.com/INGInious/INGInious/tree/main/base-containers/default) so that the project deployment from sources is self-contained.

Thanks for the review! I will open the PR for merge once I have a functional BIER data-plane.