Andres
Andres
I made especially sure not to change any existing API, and to hide all of the new types/traits in the existing internal module to not increase the public API surface...
> > I made especially sure not to change any existing API, and to hide all of the new types/traits in the existing internal module to not increase the public...
@Lorak-mmk congrats on the v1.0 release! 🎉 . I have rebased this PR against the `main` branch so it should be good to be reviewed whenever
> This looks really useful, but wondering if the flatten attribute can also be added to derive SerializeValue, which I'm using for a bunch of UDTs I have in my...
> 🚀 🎉 🦀 This is one of the highest quality external contributions I've ever reviewed! Great job! Thank you for the compliment and the review! (: I have addressed...
@wprzytula are there any other changes necessary for this PR?
@wprzytula is there anything needed for merging?
I know this PR is pretty big so I really appreciate the time and effort you are all taking in reviewing this and giving me some great feedback (:
> Oh, actually one more thing: in the previous review I proposed using https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-diagnosticon_unimplemented-attribute to improving error message when the user tries to use `#[flatten]` on a field that does...
> I took a stab at writing those messages, but I see you were faster. My commits are available at: https://github.com/Lorak-mmk/scylla-rust-driver/tree/flatten-serialize-name I'm not sure which messages are better, mine or...