nx icon indicating copy to clipboard operation
nx copied to clipboard

Parallel with fraction number

Open ianzone opened this issue 6 months ago • 2 comments

Before: parallel accept 3, "3" or "30%" After: parallel accept 3, "3", "30%", 0.3 or "0.3"

ianzone avatar Jun 13 '25 12:06 ianzone

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 21, 2025 3:03pm

vercel[bot] avatar Jun 13 '25 12:06 vercel[bot]

🤖 Nx Cloud AI has a fix for the failures below

Fix TypeScript compilation errors by resolving ExecutorContext type conflicts

🟢 Verified, ready to apply • View Fix ↗


View your CI Pipeline Execution ↗ for commit d7984edaad7a7a975adc30871d4e5f2a988fe09d

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 10m 45s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 57s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 2m 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-21 15:04:46 UTC

nx-cloud[bot] avatar Jun 13 '25 12:06 nx-cloud[bot]

Hi, can someone give it a look?

ianzone avatar Jun 19 '25 19:06 ianzone

Hi, it's been a while. Could this be merged?

ianzone avatar Jul 07 '25 13:07 ianzone

The error log seems irrelevant to my commits. Is that something I need to fix?

ianzone avatar Jul 21 '25 15:07 ianzone

Hey @ianzone! Thanks for the effort in improving Nx. As we talked about in your last PR, we prefer the %-based syntax because it's more in line with what other tools do. Having a fractional number doesn't really add anything beyond that and we don't think there's an upside to supporting multiple different ways of doing the same thing - it will just be more confusing and harder to maintain.

I'll close this PR for now but if you have a clear use case that specifying 0.4 vs 40% unlocks, I'd love to hear about it.

Thanks!

MaxKless avatar Jul 22 '25 12:07 MaxKless

Hey @ianzone! Thanks for the effort in improving Nx. As we talked about in your last PR, we prefer the %-based syntax because it's more in line with what other tools do. Having a fractional number doesn't really add anything beyond that and we don't think there's an upside to supporting multiple different ways of doing the same thing - it will just be more confusing and harder to maintain.

I'll close this PR for now but if you have a clear use case that specifying 0.4 vs 40% unlocks, I'd love to hear about it.

Thanks!

A real customer walks into the bar and asks where the bathroom is. The bar goes up in flames.

30% equals 0.3. It's intuitive, thus people will use it, and it would be wrong to result in one thread.

Another upside, 0.3 presses fewer keys than 30%.

ianzone avatar Jul 22 '25 15:07 ianzone

I don't think it's a different syntax since 0.3 and 30% are all arithmetic expressions.

"thirty percent" and 30% are different ways, though.

ianzone avatar Jul 22 '25 15:07 ianzone

Hi @MaxKless , are the reasons good enough?

ianzone avatar Jul 24 '25 16:07 ianzone

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Jul 28 '25 00:07 github-actions[bot]