nx icon indicating copy to clipboard operation
nx copied to clipboard

feat(linter): create new workspaces with ESLint v9 and typescript-eslint v8

Open JamesHenry opened this issue 1 year ago • 2 comments

Closes #27451

JamesHenry avatar Aug 13 '24 12:08 JamesHenry

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 6:38pm

vercel[bot] avatar Aug 13 '24 12:08 vercel[bot]

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-27404-9b7456c
Release details 📑
Published version 0.0.0-pr-27404-9b7456c
Triggered by @jaysoo
Branch eslint-v9-for-new-workspaces
Commit 9b7456c
Workflow run 10817714102

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

github-actions[bot] avatar Sep 11 '24 19:09 github-actions[bot]

hi @JamesHenry first of all thank you so much for completing the work for this but I have a question why in the new project now it doesn't use tseslint.config function e.g.

const nx = require('@nx/eslint-plugin');
const tsEslint = require('typescript-eslint');

module.exports = tsEslint.config(
  ...nx.configs['flat/base'],
...

instead of now

const nx = require('@nx/eslint-plugin');

module.exports = [
  ...nx.configs['flat/base'],
...

as it provides help assistance when you try to modify the file

robertIsaac avatar Sep 16 '24 19:09 robertIsaac

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Sep 25 '24 00:09 github-actions[bot]