nx icon indicating copy to clipboard operation
nx copied to clipboard

Nx not able to migrate angular material and Angular CDK from 9.X.X to 11.X.X

Open Jay1989 opened this issue 1 year ago • 1 comments

Current Behavior

We are trying to migrate old Angular mono repo project which is in 9.x.x to 11.x.x, all packages are migrated except Angular Material and CDK. our migration.json file is like below: { "migrations": [ { "version": "10.0.0-0", "description": "Updates Angular Material to v10", "factory": "./ng-update/index#updateToV10", "package": "@angular/material", "name": "migration-v10" }, { "version": "11.0.0-0", "description": "Updates Angular Material to v11", "factory": "./ng-update/index#updateToV11", "package": "@angular/material", "name": "migration-v11" }, { "version": "10.0.0-0", "description": "Updates the Angular CDK to v10", "factory": "./ng-update/index#updateToV10", "package": "@angular/cdk", "name": "migration-v10" }, { "version": "11.0.0-0", "description": "Updates the Angular CDK to v11", "factory": "./ng-update/index#updateToV11", "package": "@angular/cdk", "name": "migration-v11" } ] } while running migration command "nx migrate --run-migrations=migrations.json" it stuck and not moving further image

Expected Behavior

Migration should be smooth

GitHub Repo

No response

Steps to Reproduce

  1. set NX_MIGRATE_USE_LOCAL=true
  2. set NG_DISABLE_VERSION_CHECK=true
  3. nx migrate @angular/[email protected]
  4. nx migrate @angular/[email protected]
  5. npm install
  6. nx migrate --run-migrations=migrations.json

Nx Report

C:\CI-UI-Workspace\WOA_Workspace5\CI-UI-Workspace>nx report

>  NX  Report complete - copy this into the issue template

  Node : 14.15.0
  OS   : win32 x64
  npm  : 6.14.8

  nx : Not Found
  @nrwl/angular : 12.2.0
  @nrwl/cli : 12.2.0
  @nrwl/cypress : 12.2.0
  @nrwl/devkit : 12.2.0
  @nrwl/eslint-plugin-nx : Not Found
  @nrwl/express : Not Found
  @nrwl/jest : 12.2.0
  @nrwl/linter : 12.2.0
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : 12.2.0
  @nrwl/react : Not Found
  @nrwl/schematics : Not Found
  @nrwl/tao : 12.2.0
  @nrwl/web : Not Found
  @nrwl/workspace : 12.2.0
  @nrwl/storybook : Not Found
  @nrwl/gatsby : Not Found
  typescript : 4.1.4

Failure Logs

>  NX  Running migrations from 'migrations.json'

Running migration migration-v10

Package Manager Version

No response

Operating System

  • [ ] macOS
  • [ ] Linux
  • [X] Windows
  • [ ] Other (Please specify)

Additional Information

node version: 14.15.0 npm version: 6.14.8

Jay1989 avatar Jun 24 '24 06:06 Jay1989

Deploy Preview for authentik-storybook canceled.

Name Link
Latest commit b55fffc7a170d31d261c2aacc382d6d03b376ab0
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6685c04bdeff3000081a9597

netlify[bot] avatar Jun 18 '24 21:06 netlify[bot]

Deploy Preview for authentik-docs ready!

Name Link
Latest commit b55fffc7a170d31d261c2aacc382d6d03b376ab0
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6685c04b9a490c0008858610
Deploy Preview https://deploy-preview-10158--authentik-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 18 '24 21:06 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.61%. Comparing base (7f17c5f) to head (b55fffc). Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10158      +/-   ##
==========================================
- Coverage   92.62%   92.61%   -0.02%     
==========================================
  Files         712      713       +1     
  Lines       34924    34999      +75     
==========================================
+ Hits        32350    32413      +63     
- Misses       2574     2586      +12     
Flag Coverage Δ
e2e 49.55% <ø> (-0.04%) :arrow_down:
integration 25.38% <ø> (-0.03%) :arrow_down:
unit 90.10% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 18 '24 21:06 codecov[bot]

Let's add a Co-authored-by: "Brian, Chen" <[email protected]> when merging.

rissson avatar Jun 19 '24 13:06 rissson

so its not that button oops

dominic-r avatar Jun 19 '24 15:06 dominic-r

@marc can you take a look at the lint(black) and lint(ruff) check fails? I'm not sure why a .py file is being discussed, lol?

If it's a check we can safely ignore, please approve PR and I'll get it merged. Thanks!

tanberry avatar Jul 03 '24 21:07 tanberry