nx icon indicating copy to clipboard operation
nx copied to clipboard

feat(misc): v19 cleanup for Nx plugins

Open jaysoo opened this issue 1 year ago • 2 comments

This PR removes deprecated code that's been slated for removal in Nx 19 - mentioned as TODO(v19) comments.

Breaking Changes

  • CNW: create-nx-workspace no longer support --preset=empty and --preset=core, use --preset=apps and --preset=npm respectively. Deprecated in Nx 15.9.
  • JS: classProperties.loose option removed from @nx/js/babel preset, use loose instead. Deprecated in Nx 17.0.
  • Next.js: NX_ environment variables are no longer bundled into Next.js apps, use NEXT_PUBLIC instead. Deprecated in Nx 17.0.
  • Next.js: withStylus removed from @nx/next, use SASS instead. It hasn't worked, but we kept the file to throw an error when used. Deprecated in Nx 17.0.
  • Next.js: @nx/next:component and @nx/next:page generators no longer derive the components and app/pages directory. Use nx g @nx/next:component apps/myapp/components/button instead. Deprecated in Nx 17.0.
  • Webpack, Storybook, Esbuild: NX_ environment variables are no longer bundled into browser bundles, use NX_PUBLIC instead. Deprecated in Nx 18.
  • Webpack: isolatedConfig option removed from @nx/webpack:webpack executor. There is a migration to handle this in Nx 19. Deprecated in in Nx 17.2.
  • Cypress: cypressComponentConfiguration generator removed from @nx/cypress, use configurationGeneratorinstead. Deprecated in Nx 17.0.
  • Cypress: cypressProjectGenerator generator removed from @nx/cypress, use configurationGenerator instead. Deprecated in Nx 15.9.
  • Angular: executeWebpackDevServerBuilder removed from @nx/angular/executors, use executeDevServerBuilder instead. Deprecated in Nx 17.2.
  • Expo: withNxWebpack removed from @nx/expo, use metro bundler (https://docs.expo.dev/guides/customizing-metro/) in app.json instead. There is a migration to handle this in Nx 19. Deprecated in Nx 15.8.

Deferred to v20

  • ESLint has a low priority task to "deviations from @typescript-eslint/recommended" for our lint rules. @JamesHenry will look at this later before Nx 20, but it is unimportant.
  • React component testing does not work with Project Crystal, and we need the executor + built-in webpack configs to run CT. Will do a follow-up on this after Nx 19 release. Related issue: https://github.com/nrwl/nx/issues/21546

jaysoo avatar Apr 30 '24 21:04 jaysoo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 2, 2024 4:48pm

vercel[bot] avatar Apr 30 '24 21:04 vercel[bot]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar May 11 '24 00:05 github-actions[bot]