fix(module-federation): Throw an error if remote is invalid

[ndcunningham]

If you are generating a remote using --dynamic either by using the host generator or the remote generator we now check to ensure that the remote name is a valid JavaScript variable.

If this is not done the app with be invalid and unable to be ran or bundled.

closes: #23024

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	May 9, 2024 4:21pm

[nx-cloud[bot]]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4571f5d19ef0202ea4c1cc8bf34ca9adac663bdf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=bf9060418012a8ba36b22aa04b2cec83458cd8ba --head=4571f5d19ef0202ea4c1cc8bf34ca9adac663bdf --parallel=1
• nx affected --targets=lint,test,build --base=bf9060418012a8ba36b22aa04b2cec83458cd8ba --head=4571f5d19ef0202ea4c1cc8bf34ca9adac663bdf --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=bf9060418012a8ba36b22aa04b2cec83458cd8ba --head=4571f5d19ef0202ea4c1cc8bf34ca9adac663bdf
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=bf9060418012a8ba36b22aa04b2cec83458cd8ba --head=4571f5d19ef0202ea4c1cc8bf34ca9adac663bdf

---

Sent with 💌 from NxCloud.

[github-actions[bot]]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.