feat(core): add support for pnpm lockfile v9

[meeroslav]

• [X] Fix parenthesis separator detection
• [x] Fix leading dash detection
• [x] Migrate existing pnpm normalizer to latest code
• [X] Add unit tests for v9
• [X] Dogfooding Pnpm v9 to Nx repo and agents

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #22850

Potentially fixes #23256

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	May 27, 2024 4:41pm

[nx-cloud[bot]]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b0f2b145a7a6c6aea1674f18de7195f06c36c551. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --targets=e2e,e2e-ci --base=e32b81961ffd4f594c446e5a705e6d746a91791c --head=b0f2b145a7a6c6aea1674f18de7195f06c36c551 --parallel=1

✅ Successfully ran 5 targets

• nx affected --targets=lint,test,build --base=e32b81961ffd4f594c446e5a705e6d746a91791c --head=b0f2b145a7a6c6aea1674f18de7195f06c36c551 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=e32b81961ffd4f594c446e5a705e6d746a91791c --head=b0f2b145a7a6c6aea1674f18de7195f06c36c551
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=e32b81961ffd4f594c446e5a705e6d746a91791c --head=b0f2b145a7a6c6aea1674f18de7195f06c36c551

---

Sent with 💌 from NxCloud.

[mattfysh]

great work @meeroslav ! would it also be useful to raise an error if the lockfileVersion encountered is outside the expected range?

[mattfysh]

@meeroslav please don't blindly accept lockfiles whose versions are higher than 9, this is how the release of pnpm v9 caused all sorts of issues that didn't immediately map back to lockfile format support

please, if the lockfileVersion > 9 then throw an error to indicate that nx does not support that lockfile - this will save a lot of headaches in future

[meeroslav]

Thank you @mattfysh, that's a good feedback.

[terrymun]

This is amazing news! That’s the last link in the chain needed for pnpm@9 support for Nx 🙌 thank you so much

[github-actions[bot]]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.