nx icon indicating copy to clipboard operation
nx copied to clipboard

fix(vite): get tsconfig from new path including target

Open ms-tng opened this issue 1 year ago • 2 comments

Current Behavior

Since v18.2.3 (e4c4697f69cf29c50aced1997715a7da5f680e23) the tsconfig.generated.json file generated if "buildLibsFromSource": false is placed under a path containing the current build target. The nx-tsconfig-paths plugin of @nx/vite was not updated accordingly, so now it doesn't find tsconfig.generated.json, effectively causing @nx/vite to ignore the "buildLibsFromSource": false setting.

Expected Behavior

With this PR, nx-tsconfig-paths finds tsconfig.generated.json at the correct path, so "buildLibsFromSource": false works as it did before v18.2.3.

ms-tng avatar Apr 11 '24 08:04 ms-tng

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 11:58am

vercel[bot] avatar Apr 11 '24 08:04 vercel[bot]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar May 19 '24 00:05 github-actions[bot]