fix(webpack): correctly handle parentheses in url

[ryanhaugh]

trafficstars

https://github.com/nrwl/nx/pull/20988 introduced a regression that caused parentheses in url not to be handled correctly.

The referenced PR copies the fix done in https://github.com/angular/angular-cli/pull/23691, but that fix introduced a regression that caused parentheses in url not to be handled correctly. https://github.com/angular/angular-cli/pull/23774 fixed this issue - that's fix that is in this PR.

Current Behavior

Parentheses in url are not handled correctly.

Expected Behavior

Parentheses in url are handled correctly.

Related Issue(s)

Fixes https://github.com/nrwl/nx/issues/21656

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Feb 14, 2024 8:04pm

[nx-cloud[bot]]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0a08e6bcda33b83ce7f7d3184b882799b471ea02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected -t e2e-macos --parallel=1 --base=3b384c78ac3d94b92b1233c251edcdcf203a5826 --head=0a08e6bcda33b83ce7f7d3184b882799b471ea02

✅ Successfully ran 5 targets

• nx affected --target=e2e --base=3b384c78ac3d94b92b1233c251edcdcf203a5826 --head=0a08e6bcda33b83ce7f7d3184b882799b471ea02 --parallel=1
• nx affected --targets=lint,test,build --base=3b384c78ac3d94b92b1233c251edcdcf203a5826 --head=0a08e6bcda33b83ce7f7d3184b882799b471ea02 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=3b384c78ac3d94b92b1233c251edcdcf203a5826 --head=0a08e6bcda33b83ce7f7d3184b882799b471ea02
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[ryanhaugh]

Hi @mandarini,

Any chance we could get this reviewed? This is preventing us from upgrading to v18.

Thanks! Ryan

[danr-za]

Same here

Hi @mandarini,

Any chance we could get this reviewed? This is preventing us from upgrading to v18.

Thanks! Ryan

[mandarini]

@ryanhaugh @danr-za hello! Sorry, I was on PTO, I just returned to work. Can you please rebase & fix e2e tests? I will approve once the pipeline is green! Thank you SO MUCH for your contribution!!

[mandarini]

Closing because this was merged: https://github.com/nrwl/nx/pull/21884

[github-actions[bot]]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.