nx icon indicating copy to clipboard operation
nx copied to clipboard

`nx release`: version generator regression - invokes yarn.lock update by default

Open Hotell opened this issue 1 year ago • 0 comments

Current Behavior

when running yarn nx release version , after version bumps are emitted , yarn lockfile update is triggered (yarn install).

Updating yarn lock file

In bigger repos, this causes significant lag and CPU useage bump when invoking nx release version

This wasn't happening in version 17.2.

Expected Behavior

Not sure what's the reasoning behind this behaviour.

My assumption is in order to refresh links within node modules if monorepo uses workspaces. If that's the case I'm wondering why is that needed as no implementation is being changed besides static package.json files that have no effect on funciionality

I'd assume this shouldn't be turned on by default rather opt in.

ATM mitigation/workaround is to turn this off ( based on versionGenerator schema )

"version": {
          "generatorOptions": {
            "skipLockFileUpdate": true
          }
        }

GitHub Repo

https://github.com/microsoft/fluentui/pull/30251

Steps to Reproduce

  1. checkout branch
  2. yarn nx release version patch -g northstar

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 18.18.2
   OS     : darwin-arm64
   yarn   : 1.23.34
   
   nx                 : 17.3.0
   lerna              : 8.0.1
   @nx/js             : 17.3.0
   @nx/jest           : 17.3.0
   @nx/linter         : 17.3.0
   @nx/eslint         : 17.3.0
   @nx/workspace      : 17.3.0
   @nx/devkit         : 17.3.0
   @nx/eslint-plugin  : 17.3.0
   @nx/node           : 17.3.0
   @nx/plugin         : 17.3.0
   @nrwl/tao          : 17.3.0
   typescript         : 4.7.4
   ---------------------------------------
   Local workspace plugins:
         @fluentui/workspace-plugin

Failure Logs

No response

Package Manager Version

yarn v1

Operating System

  • [X] macOS
  • [ ] Linux
  • [ ] Windows
  • [ ] Other (Please specify)

Additional Information

No response

Hotell avatar Jan 31 '24 16:01 Hotell