nx icon indicating copy to clipboard operation
nx copied to clipboard

feat(expo): support cjs and mjs

Open yzhe554 opened this issue 1 year ago • 2 comments

Current Behavior

The init script won't support cjs and mjs by default

Expected Behavior

There are some third party libraries are using cjs and mjs, for user's benefits, support cjs and mjs by default.

Related Issue(s)

Fixes #

yzhe554 avatar Jan 30 '24 08:01 yzhe554

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 8, 2024 8:53am

vercel[bot] avatar Jan 30 '24 08:01 vercel[bot]

@yzhe554 besides the migration script, could you update the metro.config file at packages/expo/src/generators/application/files/metro.config.js.template and packages/react-native/src/generators/application/files/app/metro.config.js.template?

xiongemi avatar Feb 01 '24 16:02 xiongemi

@yzhe554 besides the migration script, could you update the metro.config file at packages/expo/src/generators/application/files/metro.config.js.template and packages/react-native/src/generators/application/files/app/metro.config.js.template?

Thanks @xiongemi , it's updated.

yzhe554 avatar Feb 05 '24 02:02 yzhe554

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Feb 14 '24 00:02 github-actions[bot]