nx
nx copied to clipboard
fix(js): post-process skipped tasks by the ts compiler in tsc batch implementation
Current Behavior
When running a task with the @nx/js:tsc
executor in batch mode, if the TS compiler detects that it doesn't need to run a build for the task, the task is scheduled to run infinitely. This happens because there's no result for the task reported back to the task orchestrator and therefore, the batch is scheduled to run again.
Expected Behavior
The batch implementation of the @nx/js:tsc
executor should correctly handle tasks that are not needed to be built by TS.
If Nx identifies a task to be processed and the TS compiler skips it, we still run the post-compilation operations to ensure any changes are properly handled (e.g. asset changes). We ensure results are reported for all tasks.
Related Issue(s)
Fixes #
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nx-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 10, 2023 7:51am |
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 4f4f664f6da9cf95a5ef526616628d9b10079b88. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 1 target
Sent with 💌 from NxCloud.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.