nx icon indicating copy to clipboard operation
nx copied to clipboard

cleanup(bundling): fix esbuild e2e test case

Open leosvelperez opened this issue 1 year ago • 2 comments

Current Behavior

A wrong utility is used to run an Nx command in an E2E test case for esbuild and a wrong path in an expectation is used.

Also, the test failure has been occurring for a long time, but it's not reported because runCommand doesn't fail by default. This can be seen in any previous run. Jest reports the test as a success https://staging.nx.app/runs/g4sVD6EWCm/task/e2e-esbuild%3Ae2e even though it's failing.

Expected Behavior

The E2E test cases should succeed.

Related Issue(s)

Fixes #

leosvelperez avatar Jun 30 '23 15:06 leosvelperez

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 11:37am

vercel[bot] avatar Jun 30 '23 15:06 vercel[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5b6ea85e94690f86058d423d0a07521b61beade3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jun 30 '23 15:06 nx-cloud[bot]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Jul 17 '23 00:07 github-actions[bot]