nx icon indicating copy to clipboard operation
nx copied to clipboard

feat(vite): add tsconfig paths resolution plugin

Open barbados-clemens opened this issue 2 years ago • 3 comments

Current Behavior

vite-tsconfig-paths plugin isn't able to work with tmp tsconfigs to make incremental building work

Expected Behavior

nx supports incremental building with vite

Related Issue(s)

terminal output showing number of modules transformed being less when using incremental building

TODO:

  • [x] validation across different vite setups with/without buildable libs
  • [x] write e2e tests
  • [x] handle TODOs
  • [x] cleanup register work within executor to just generate tsconfigs

Fixes #

barbados-clemens avatar Jun 28 '23 20:06 barbados-clemens

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 3:22pm

vercel[bot] avatar Jun 28 '23 20:06 vercel[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ce7876d052067c85630c75bf17ccc65b39bf330d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jun 28 '23 20:06 nx-cloud[bot]

Cool! So, yes, I tested on this repo: https://github.com/mandarini/vite-paths/tree/test-caleb on the branch test-caleb, which I added lots of interdependencies, and some to cover Storybook path resolution as well. All works great! So it's a ✅ from me, but with the question whether we really want to drop vite-tsconfig-paths completely, and not rely on it at all!

mandarini avatar Jul 03 '23 12:07 mandarini

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Jul 23 '23 00:07 github-actions[bot]