nx icon indicating copy to clipboard operation
nx copied to clipboard

docs(linter): [eslint-plugin] improve error message for forbidden imp…

Open miluoshi opened this issue 2 years ago • 2 comments

…orts of lazy-loaded libs

  • Specify that static imports are forbidden
  • Include target library name and source file path containing a dynamic import that triggered this rule

Related Issue(s)

Related to #17425

miluoshi avatar Jun 16 '23 14:06 miluoshi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 2:38pm

vercel[bot] avatar Jun 16 '23 14:06 vercel[bot]

Thank you @miluoshi,

I left one small improvement point.

(also PR is failing due to format:check, please run pnpm nx format and push the re-formatted code)

meeroslav avatar Jun 19 '23 08:06 meeroslav

Thanks for the suggestion. Updated.

miluoshi avatar Jun 19 '23 09:06 miluoshi

Thank you, I will add one unit test to test this and then we can merge it.

meeroslav avatar Jun 19 '23 10:06 meeroslav

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Jun 25 '23 00:06 github-actions[bot]