nx
nx copied to clipboard
fix(core): ignore nested node_module paths for findProjectOfResolvedModule in TargetProjectLocator
Current Behavior
TargetProjectLocator's findProjectOfResolvedModule will treat unknown imports as the source project if import is pointing to nested node_modules.
Expected Behavior
The findProjectOfResolvedModule should check if module path contains node_modules (not only if it starts with one)
Related Issue(s)
Fixes #15957
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| nx-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 16, 2023 1:19pm |
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 3a4f7f7dabefc4b253ea0618aad738b02a883a06. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 8 targets
nx affected -t e2e-macos --parallel=1 --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=3a4f7f7dabefc4b253ea0618aad738b02a883a06nx affected --target=e2e --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=3a4f7f7dabefc4b253ea0618aad738b02a883a06 --parallel=1nx affected --target=test --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=3a4f7f7dabefc4b253ea0618aad738b02a883a06 --parallel=1nx affected --target=build --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=3a4f7f7dabefc4b253ea0618aad738b02a883a06 --parallel=3nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners documentation --parallel=1 --no-dtenx affected --target=lint --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=3a4f7f7dabefc4b253ea0618aad738b02a883a06 --parallel=3nx-cloud record -- nx format:check --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=3a4f7f7dabefc4b253ea0618aad738b02a883a06nx documentation --no-dte
Sent with 💌 from NxCloud.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.