nx
nx copied to clipboard
fix(core): ensure correct package name matching when parsing pnpm lock file
Current Behavior
Package name matcher in the pnpm-parser will match key to alias name if found, and ignore the potential full name match.
# ...
/@isaacs/[email protected]:
dependencies:
string-width: 5.1.2
string-width-cjs: /[email protected] # alias for string-width: 4.2.3
/[email protected]:
dependencies:
string-width: 4.2.3
# ...
/[email protected]:
# ...
/[email protected]:
# ...
# ...
The above yaml would match 2 packages:
- string-width @ 5.1.2
- string-width-cjs @ 4.2.3 While skipping the:
- string-width @ 4.2.3
Expected Behavior
If same package version is used in the original form and as an alias, both variants should be saved to graph, so that we can track them when finding dependency subgraph and pruning.
Related Issue(s)
Fixes #17492
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| nx-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 15, 2023 9:54am |
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 7001f3cad1d8fca91159fefb11de47c20210e4a1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 8 targets
nx affected -t e2e-macos --parallel=1 --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=7001f3cad1d8fca91159fefb11de47c20210e4a1nx affected --target=e2e --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=7001f3cad1d8fca91159fefb11de47c20210e4a1 --parallel=1nx affected --target=build --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=7001f3cad1d8fca91159fefb11de47c20210e4a1 --parallel=3nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners documentation --parallel=1 --no-dtenx affected --target=lint --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=7001f3cad1d8fca91159fefb11de47c20210e4a1 --parallel=3nx affected --target=test --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=7001f3cad1d8fca91159fefb11de47c20210e4a1 --parallel=1nx-cloud record -- nx format:check --base=a19fbb1ddba384932e07d0df06dfe6f182cd8782 --head=7001f3cad1d8fca91159fefb11de47c20210e4a1nx documentation --no-dte
Sent with 💌 from NxCloud.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.