fix(vite): add ability to specify reportCompressedSize for vite build
vite has build option reportCompressedSize, it enables/disables calculation of gzip size of the output files. compressing large output files can be slow, so disabling this may increase build performance for large projects or in cases where it is unnecessary
Current Behavior
vite executor rewrites the value of specified reportCompressedSize option with 'true'
Expected Behavior
vite executor uses the value of reportCompressedSize option if specified, otherwise set it to 'true'
Related Issue(s)
Fixes #
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| nx-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 13, 2023 10:33am |
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 415baa019730bb12f9a3392910aef4e00e2ef3d9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 8 targets
nx affected -t e2e-macos --parallel=1 --base=2d47f1bdbee607718be8ceac2471624bffeb23dc --head=415baa019730bb12f9a3392910aef4e00e2ef3d9nx affected --target=e2e --base=2d47f1bdbee607718be8ceac2471624bffeb23dc --head=415baa019730bb12f9a3392910aef4e00e2ef3d9 --parallel=1nx affected --target=test --base=2d47f1bdbee607718be8ceac2471624bffeb23dc --head=415baa019730bb12f9a3392910aef4e00e2ef3d9 --parallel=1nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners documentation --parallel=1 --no-dtenx affected --target=build --base=2d47f1bdbee607718be8ceac2471624bffeb23dc --head=415baa019730bb12f9a3392910aef4e00e2ef3d9 --parallel=3nx affected --target=lint --base=2d47f1bdbee607718be8ceac2471624bffeb23dc --head=415baa019730bb12f9a3392910aef4e00e2ef3d9 --parallel=3nx-cloud record -- nx format:check --base=2d47f1bdbee607718be8ceac2471624bffeb23dc --head=415baa019730bb12f9a3392910aef4e00e2ef3d9nx documentation --no-dte
Sent with 💌 from NxCloud.
Hi there @friedbizkvit ! Thank you SO much for your PR!!!!
We have made so many changes since you submitted this. Essentially, you can pass any arg to vite, and Nx will pass it down. We are moving away from executors, so now we suggest you either use the Vite CLI or add the options in your vite.config.ts.
Unfortunately, this means that I will have to close your PR, but thank you so much for taking the time!!!!
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.