nx icon indicating copy to clipboard operation
nx copied to clipboard

fix(vite): add ability to specify reportCompressedSize for vite build

Open friedbizkvit opened this issue 2 years ago • 2 comments

vite has build option reportCompressedSize, it enables/disables calculation of gzip size of the output files. compressing large output files can be slow, so disabling this may increase build performance for large projects or in cases where it is unnecessary

Current Behavior

vite executor rewrites the value of specified reportCompressedSize option with 'true'

Expected Behavior

vite executor uses the value of reportCompressedSize option if specified, otherwise set it to 'true'

Related Issue(s)

Fixes #

friedbizkvit avatar May 31 '23 11:05 friedbizkvit

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 10:33am

vercel[bot] avatar May 31 '23 11:05 vercel[bot]

Hi there @friedbizkvit ! Thank you SO much for your PR!!!!

We have made so many changes since you submitted this. Essentially, you can pass any arg to vite, and Nx will pass it down. We are moving away from executors, so now we suggest you either use the Vite CLI or add the options in your vite.config.ts.

Unfortunately, this means that I will have to close your PR, but thank you so much for taking the time!!!!

mandarini avatar Jan 29 '24 17:01 mandarini

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Feb 04 '24 00:02 github-actions[bot]