nx
nx copied to clipboard
Remove expo-cli package and update references to use @expo/cli
Port of nrwl/nx-labs#120
As of Expo SDK 46, expo-cli is deprecated and can be removed in favor of @expo/cli which is bundled in the expo installation now.
Current Behavior
We are currently using expo-cli along with Expo SDK 46. However, expo-cli does not support Node v18, so this causes issues when installing dependencies without using the --ignore-engines flag in yarn. Simply removing the package breaks functionality because @nrwl/expo command wrappers are stil pointing to expo-cli package.
Expected Behavior
- Node v18 support, package managers can install/update without
--ignore-enginesflag. @nrwl/expocommand wrappers function withoutexpo-cliinstalled.
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 950081cbbb5c32f60286e264868d58a2deec81e0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 12 targets
nx affected --target=e2e --base=2d84bd3eb4c6facdb522e4853c987229feec9ae1 --head=950081cbbb5c32f60286e264868d58a2deec81e0 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1nx affected --target=test --base=2d84bd3eb4c6facdb522e4853c987229feec9ae1 --head=950081cbbb5c32f60286e264868d58a2deec81e0 --parallel=1nx-cloud record -- yarn depchecknx affected --target=lint --base=2d84bd3eb4c6facdb522e4853c987229feec9ae1 --head=950081cbbb5c32f60286e264868d58a2deec81e0 --parallel=3nx affected --target=build --base=2d84bd3eb4c6facdb522e4853c987229feec9ae1 --head=950081cbbb5c32f60286e264868d58a2deec81e0 --parallel=3nx-cloud record -- yarn nx workspace-lintnx-cloud record -- yarn check-lock-filesnx-cloud record -- yarn check-commitnx-cloud record -- yarn nx format:check --base=2d84bd3eb4c6facdb522e4853c987229feec9ae1 --head=950081cbbb5c32f60286e264868d58a2deec81e0nx-cloud record -- yarn check-importsnx-cloud record -- yarn documentationnx build typedoc-theme
Sent with 💌 from NxCloud.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Updated |
|---|---|---|---|
| nx-dev | ⬜️ Ignored (Inspect) | Sep 21, 2022 at 4:24PM (UTC) |
thanks for submitting the pr. i include the fix in pr: https://github.com/nrwl/nx/pull/12799
I'm closing this out since the changes were integrated as mentioned by @xiongemi
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.