nx icon indicating copy to clipboard operation
nx copied to clipboard

Remove expo-cli package and update references to use @expo/cli

Open impleri opened this issue 3 years ago • 2 comments

Port of nrwl/nx-labs#120

As of Expo SDK 46, expo-cli is deprecated and can be removed in favor of @expo/cli which is bundled in the expo installation now.

Current Behavior

We are currently using expo-cli along with Expo SDK 46. However, expo-cli does not support Node v18, so this causes issues when installing dependencies without using the --ignore-engines flag in yarn. Simply removing the package breaks functionality because @nrwl/expo command wrappers are stil pointing to expo-cli package.

Expected Behavior

  • Node v18 support, package managers can install/update without --ignore-engines flag.
  • @nrwl/expo command wrappers function without expo-cli installed.

impleri avatar Sep 21 '22 15:09 impleri

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 21, 2022 at 4:24PM (UTC)

vercel[bot] avatar Sep 21 '22 15:09 vercel[bot]

thanks for submitting the pr. i include the fix in pr: https://github.com/nrwl/nx/pull/12799

xiongemi avatar Oct 24 '22 23:10 xiongemi

I'm closing this out since the changes were integrated as mentioned by @xiongemi

AgentEnder avatar Oct 25 '22 18:10 AgentEnder

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Mar 17 '23 12:03 github-actions[bot]