nx
nx copied to clipboard
feat(nx-plugin): allow skipping the creation of an e2e project
Current Behavior
Currently there is no option to skip the creation of an E2E project when generating an Nx Plugin.
Expected Behavior
Ideally the creation of an e2e project should be optional.
Related Issue(s)
N/A
☁️ Nx Cloud Report
CI is running/has finished running commands for commit d79929116280051aff9760fb25739c781e01e720. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 12 targets
nx affected --target=e2e --base=d390044dc826257ee4ac1b7bb16a0cfb1cb76926 --head=d79929116280051aff9760fb25739c781e01e720 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1nx affected --target=build --base=d390044dc826257ee4ac1b7bb16a0cfb1cb76926 --head=d79929116280051aff9760fb25739c781e01e720 --parallel=3nx affected --target=test --base=d390044dc826257ee4ac1b7bb16a0cfb1cb76926 --head=d79929116280051aff9760fb25739c781e01e720 --parallel=1nx-cloud record -- yarn depchecknx affected --target=lint --base=d390044dc826257ee4ac1b7bb16a0cfb1cb76926 --head=d79929116280051aff9760fb25739c781e01e720 --parallel=3nx-cloud record -- yarn nx workspace-lintnx-cloud record -- yarn check-lock-filesnx-cloud record -- yarn check-commitnx-cloud record -- yarn nx format:check --base=d390044dc826257ee4ac1b7bb16a0cfb1cb76926 --head=d79929116280051aff9760fb25739c781e01e720nx-cloud record -- yarn check-importsnx-cloud record -- yarn documentationnx build typedoc-theme
Sent with 💌 from NxCloud.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| nx-dev | ✅ Ready (Inspect) | Visit Preview | Sep 22, 2022 at 10:30PM (UTC) |
Hey, thanks for the contribution. Lets make this consistent with several of our other generators, and use e2eTestRunner as the property, with options "jest", and "none".
Here's a fragment of the next app generator's schema.json as an example:
{
"properties": {
"e2eTestRunner": {
"type": "string",
"enum": ["cypress", "none"],
"description": "Test runner to use for end to end (E2E) tests.",
"default": "cypress"
}
}
}
@AgentEnder thanks very much for the feedback, I have made the suggested changes.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.