nx icon indicating copy to clipboard operation
nx copied to clipboard

feat(nx-plugin): allow skipping the creation of an e2e project

Open ashley-hunter opened this issue 3 years ago • 2 comments

Current Behavior

Currently there is no option to skip the creation of an E2E project when generating an Nx Plugin.

Expected Behavior

Ideally the creation of an e2e project should be optional.

Related Issue(s)

N/A

ashley-hunter avatar Sep 20 '22 16:09 ashley-hunter

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 10:30PM (UTC)

vercel[bot] avatar Sep 20 '22 16:09 vercel[bot]

Hey, thanks for the contribution. Lets make this consistent with several of our other generators, and use e2eTestRunner as the property, with options "jest", and "none".

Here's a fragment of the next app generator's schema.json as an example:

{
  "properties": {
    "e2eTestRunner": {
      "type": "string",
      "enum": ["cypress", "none"],
      "description": "Test runner to use for end to end (E2E) tests.",
      "default": "cypress"
    }
  }
}

AgentEnder avatar Sep 22 '22 22:09 AgentEnder

@AgentEnder thanks very much for the feedback, I have made the suggested changes.

ashley-hunter avatar Sep 22 '22 22:09 ashley-hunter

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Mar 17 '23 18:03 github-actions[bot]