nx icon indicating copy to clipboard operation
nx copied to clipboard

fix(js): use path to `rootDir` when update package.json

Open xiejay97 opened this issue 3 years ago • 2 comments

fix path when set rootDir image

xiejay97 avatar Sep 20 '22 07:09 xiejay97

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 12, 2022 at 1:03AM (UTC)

vercel[bot] avatar Sep 20 '22 07:09 vercel[bot]

@xiejay97 Hi, can you rebase from latest?

nartc avatar Oct 11 '22 02:10 nartc

@xiejay97 Hi, can you rebase from latest?

👌

xiejay97 avatar Oct 11 '22 08:10 xiejay97

@xiejay97 Hi again, sorry if I missed it but which issue does this PR solve?

nartc avatar Oct 12 '22 03:10 nartc

@nartc

The source files in src dir image

I add "rootDir": "packages/ui/src" to @nrwl/js:tsc opions and I get output image

But path of main field in package.json still depends on projectRoot , it should be ./index.js image

https://github.com/DevCloudFE/react-devui/blob/main/packages/ui/project.json

xiejay97 avatar Oct 12 '22 03:10 xiejay97

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Mar 03 '23 14:03 github-actions[bot]