nx
nx copied to clipboard
Support `allowJs` customization in the rollup executor
- [x] I'd be willing to implement this feature (contributing guide)
Description
I would like to see tsconfig.json#compilerOptions.allowJs configuration support for the rollup executor, currently, it is hardcoded as false.
Motivation
This flag allows us to produce typings from JS files and import JS files in TS files, which is very useful when migrating large JS repository files to TypeScript gradually.
Suggested Implementation
Keep false as the default value, but use the configured tsconfig.json value when present.
Alternate Implementations
Actually, I would need to understand why it's hardcoded so I can be able to discuss alternate implementations.
It seems this flag has been hardcoded since its first implementation: https://github.com/nrwl/nx/pull/1907
@jaysoo, @vsavkin, any hints on why it's hardcoded?
Up
Am I missing something on the issue template or some important info? Can't believe this hasn't been even replied and it's very common to have hybrid libraries (TS+JS), which currently can't use the rollup executor!
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.