nx icon indicating copy to clipboard operation
nx copied to clipboard

Support `allowJs` customization in the rollup executor

Open fsmaia opened this issue 3 years ago • 1 comments

Description

I would like to see tsconfig.json#compilerOptions.allowJs configuration support for the rollup executor, currently, it is hardcoded as false.

Motivation

This flag allows us to produce typings from JS files and import JS files in TS files, which is very useful when migrating large JS repository files to TypeScript gradually.

Suggested Implementation

Keep false as the default value, but use the configured tsconfig.json value when present.

Alternate Implementations

Actually, I would need to understand why it's hardcoded so I can be able to discuss alternate implementations.

fsmaia avatar Aug 04 '22 12:08 fsmaia

It seems this flag has been hardcoded since its first implementation: https://github.com/nrwl/nx/pull/1907

@jaysoo, @vsavkin, any hints on why it's hardcoded?

fsmaia avatar Aug 08 '22 15:08 fsmaia

Up

fsmaia avatar Sep 05 '22 12:09 fsmaia

Am I missing something on the issue template or some important info? Can't believe this hasn't been even replied and it's very common to have hybrid libraries (TS+JS), which currently can't use the rollup executor!

fsmaia avatar Sep 26 '22 13:09 fsmaia

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

github-actions[bot] avatar Jun 05 '23 00:06 github-actions[bot]