nx
nx copied to clipboard
feat(devkit): restrict addDependenciesToPackageJson to update versions only if greater than existing
Current Behavior
We do not update the versions of existing packages when addDependenciesToPackageJson is used
Expected Behavior
We should update the versions of existing packages when the method is used, but only if the versions are greater than the versions that currently exist. We do not want to downgrade people.
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 298d45ef4dfe7386020bd04754a2ed8bbca579c5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 12 targets
nx affected --target=e2e --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=298d45ef4dfe7386020bd04754a2ed8bbca579c5 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1nx affected --target=test --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=298d45ef4dfe7386020bd04754a2ed8bbca579c5 --parallel=1nx affected --target=build --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=298d45ef4dfe7386020bd04754a2ed8bbca579c5 --parallel=3nx-cloud record -- yarn depchecknx affected --target=lint --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=298d45ef4dfe7386020bd04754a2ed8bbca579c5 --parallel=3nx-cloud record -- yarn nx workspace-lintnx-cloud record -- yarn check-lock-filesnx-cloud record -- yarn check-commitnx-cloud record -- yarn nx format:check --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=298d45ef4dfe7386020bd04754a2ed8bbca579c5nx-cloud record -- yarn check-importsnx-cloud record -- yarn documentationnx build typedoc-theme
Sent with 💌 from NxCloud.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| nx-dev | ✅ Ready (Inspect) | Visit Preview | Sep 29, 2022 at 8:26AM (UTC) |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.