nx
nx copied to clipboard
fix(react): fix missing integrity tags in production builds
Subresource Integrity attributes were not generated on production react builds due to a missing option pass through when writing the index file.
Current Behavior
When building a react production app and generating index.html
, subresource
integrity tags were not written in to the file, even when enabled in project.json
.
Expected Behavior
When enabled, css/jss tags contain the integrity
attribute
Related Issue(s)
Fixes #10926
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 001d919e81e896f6af765760c8535b9e4b5f6ae2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 12 targets
-
nx affected --target=build --base=071ebf70cf95d1c76a605c0bc9bd3dbc68169af5 --head=001d919e81e896f6af765760c8535b9e4b5f6ae2 --parallel=3
-
nx affected --target=e2e --base=071ebf70cf95d1c76a605c0bc9bd3dbc68169af5 --head=001d919e81e896f6af765760c8535b9e4b5f6ae2 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-nx-run,e2e-nx-misc,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-add-nx-to-monorepo,nx-dev-e2e,e2...
-
nx affected --target=e2e --base=071ebf70cf95d1c76a605c0bc9bd3dbc68169af5 --head=001d919e81e896f6af765760c8535b9e4b5f6ae2 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
-
nx affected --target=lint --base=071ebf70cf95d1c76a605c0bc9bd3dbc68169af5 --head=001d919e81e896f6af765760c8535b9e4b5f6ae2 --parallel=3
-
nx affected --target=test --base=071ebf70cf95d1c76a605c0bc9bd3dbc68169af5 --head=001d919e81e896f6af765760c8535b9e4b5f6ae2 --parallel=1
-
nx build typedoc-theme
-
nx-cloud record -- yarn check-commit
-
nx-cloud record -- yarn check-imports
-
nx-cloud record -- yarn depcheck
-
nx-cloud record -- yarn documentation
-
nx-cloud record -- yarn nx format:check --base=071ebf70cf95d1c76a605c0bc9bd3dbc68169af5 --head=001d919e81e896f6af765760c8535b9e4b5f6ae2
-
nx-cloud record -- yarn nx workspace-lint
Sent with 💌 from NxCloud.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
nx-dev | ⬜️ Ignored (Inspect) | Jun 29, 2022 at 4:33PM (UTC) |
@jaysoo is there anything further I can do on this PR? Or is it unlikely to get merged?
@AgentEnder as above - is there anything I can do to make this PR mergeable?
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.