nx icon indicating copy to clipboard operation
nx copied to clipboard

fix(react): fix missing integrity tags in production builds

Open edd opened this issue 2 years ago • 2 comments

Subresource Integrity attributes were not generated on production react builds due to a missing option pass through when writing the index file.

Current Behavior

When building a react production app and generating index.html, subresource integrity tags were not written in to the file, even when enabled in project.json.

Expected Behavior

When enabled, css/jss tags contain the integrity attribute

Related Issue(s)

Fixes #10926

edd avatar Jun 29 '22 16:06 edd

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 001d919e81e896f6af765760c8535b9e4b5f6ae2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jun 29 '22 16:06 nx-cloud[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 29, 2022 at 4:33PM (UTC)

vercel[bot] avatar Jun 29 '22 16:06 vercel[bot]

@jaysoo is there anything further I can do on this PR? Or is it unlikely to get merged?

edd avatar Aug 17 '22 14:08 edd

@AgentEnder as above - is there anything I can do to make this PR mergeable?

edd avatar Aug 24 '22 16:08 edd

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Mar 18 '23 00:03 github-actions[bot]