nx icon indicating copy to clipboard operation
nx copied to clipboard

feat(testing): support jest 28

Open barbados-clemens opened this issue 2 years ago • 5 comments

Current Behavior

does not support jest 28

Expected Behavior

support jest 28

Related Issue(s)

Fixes #10117

barbados-clemens avatar Jun 22 '22 20:06 barbados-clemens

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --target=e2e --base=8e22de4d47e9c316963324a5fc00308c9a0e1a65 --head=2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1
✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jun 22 '22 20:06 nx-cloud[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Aug 18, 2022 at 9:52PM (UTC)

vercel[bot] avatar Jun 22 '22 20:06 vercel[bot]

any ETA on this?

johannesschobel avatar Jul 15 '22 08:07 johannesschobel

Hi @johannesschobel plan is to get this finished this week.

barbados-clemens avatar Jul 18 '22 20:07 barbados-clemens

for those following this, it should be good to merge pending a review, but the esbuild-wasm issue seems to be showing it's head in the e2e tests in this PR consistently unfortunely so I'll have to try to figure out a workaround so it's safe to merge this PR. I've been trying to reproduce locally but no luck :(

related issue: #10719

FAIL e2e-angular-extensions e2e/angular-extensions/src/ngrx.test.ts (196.261 s)
  ● Angular Package › ngrx › should work

    Command failed: pnpm exec nx test myapp7791666 --no-watch
    FAIL myapp7791666 apps/myapp7791666/src/app/+state/users.selectors.spec.ts
      ● Test suite failed to run

        The service was stopped

      at ../../../../node_modules/.pnpm/[email protected]/node_modules/esbuild-wasm/lib/main.js:1391:29
      at ../../../../node_modules/.pnpm/[email protected]/node_modules/esbuild-wasm/lib/main.js:669:9
      at Socket.afterClose (../../../../node_modules/.pnpm/[email protected]/node_modules/esbuild-wasm/lib/main.js:647:7)
      PASS myapp7791666 apps/myapp7791666/src/app/+state/users.reducer.spec.ts (62.986 s)
      PASS myapp7791666 apps/myapp7791666/src/app/app.component.spec.ts (63.192 s)
      PASS myapp7791666 apps/myapp7791666/src/app/+state/users.effects.spec.ts (64.325 s)
      Test Suites: 1 failed, 3 passed, 4 total
      Tests:       6 passed, 6 total
      Snapshots:   0 total
      Time:        66.031 s
      Ran all test suites.

Test Suites: 1 failed, 1 skipped, 1 passed, 2 of 3 total
Tests:       1 failed, 7 skipped, 4 passed, 12 total
Snapshots:   0 total
Time:        267.49 s
Ran all test suites.

barbados-clemens avatar Jul 26 '22 21:07 barbados-clemens

Hi @johannesschobel plan is to get this finished this week.

By reading the comments on https://github.com/nrwl/nx/issues/10117, I understood there were more stuff to fix than expected explaining the delay for this. I'm facing https://github.com/nrwl/nx/issues/10537 issue and I was wondering if you had a new ETA for this PR ?

mpellerin42 avatar Aug 17 '22 11:08 mpellerin42

@FrozenPandaz I'm a little confused. I see this PR is merged and I see that there has been an Nx release published since this merge; however, when I run nx migrate latest and nx migrate --run-migrations my jest version stays at 27. Shouldn't it be getting bumped to v28 now?

jaytavares avatar Aug 23 '22 21:08 jaytavares

Same here. I also tried to migrate to 14.6.0-beta.0 or 14.6.0-beta, but persist at 27.

rique-dev avatar Aug 23 '22 21:08 rique-dev

@jaytavares I found solution. You can try nx migrate 14.6.0-beta.7

rique-dev avatar Aug 23 '22 22:08 rique-dev

@jaytavares @rique-dev this change is included in v14.6.0 which is in beta right now. if you want to migrate to the beta version you have to use the next tag not latest.

if you want to jump to the beta you can use. nx migrate @nrwl/jest@next --from @nrwl/[email protected]

if you were already on a beta then it probably didn't get bumped correctly since the PR targeted an earlier beta that was already released.

barbados-clemens avatar Aug 23 '22 22:08 barbados-clemens

@barbados-clemens Awesome! Thx!

rique-dev avatar Aug 23 '22 22:08 rique-dev

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Mar 18 '23 00:03 github-actions[bot]