nx
nx copied to clipboard
feat(testing): support jest 28
Current Behavior
does not support jest 28
Expected Behavior
support jest 28
Related Issue(s)
Fixes #10117
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 11 targets
-
nx affected --target=build --base=8e22de4d47e9c316963324a5fc00308c9a0e1a65 --head=2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c --parallel=3
-
nx affected --target=e2e --base=8e22de4d47e9c316963324a5fc00308c9a0e1a65 --head=2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c --exclude=e2e-make-angular-cli-faster,e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-nx-run,e2e-nx-misc,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-add-...
-
nx affected --target=lint --base=8e22de4d47e9c316963324a5fc00308c9a0e1a65 --head=2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c --parallel=3
-
nx affected --target=test --base=8e22de4d47e9c316963324a5fc00308c9a0e1a65 --head=2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c --parallel=1
-
nx-cloud record -- yarn check-commit
-
nx-cloud record -- yarn check-imports
-
nx-cloud record -- yarn check-lock-files
-
nx-cloud record -- yarn depcheck
-
nx-cloud record -- yarn documentation
-
nx-cloud record -- yarn nx format:check --base=8e22de4d47e9c316963324a5fc00308c9a0e1a65 --head=2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c
-
nx-cloud record -- yarn nx workspace-lint
Sent with 💌 from NxCloud.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
nx-dev | ⬜️ Ignored (Inspect) | Aug 18, 2022 at 9:52PM (UTC) |
any ETA on this?
Hi @johannesschobel plan is to get this finished this week.
for those following this, it should be good to merge pending a review, but the esbuild-wasm issue seems to be showing it's head in the e2e tests in this PR consistently unfortunely so I'll have to try to figure out a workaround so it's safe to merge this PR. I've been trying to reproduce locally but no luck :(
related issue: #10719
FAIL e2e-angular-extensions e2e/angular-extensions/src/ngrx.test.ts (196.261 s)
● Angular Package › ngrx › should work
Command failed: pnpm exec nx test myapp7791666 --no-watch
FAIL myapp7791666 apps/myapp7791666/src/app/+state/users.selectors.spec.ts
● Test suite failed to run
The service was stopped
at ../../../../node_modules/.pnpm/[email protected]/node_modules/esbuild-wasm/lib/main.js:1391:29
at ../../../../node_modules/.pnpm/[email protected]/node_modules/esbuild-wasm/lib/main.js:669:9
at Socket.afterClose (../../../../node_modules/.pnpm/[email protected]/node_modules/esbuild-wasm/lib/main.js:647:7)
PASS myapp7791666 apps/myapp7791666/src/app/+state/users.reducer.spec.ts (62.986 s)
PASS myapp7791666 apps/myapp7791666/src/app/app.component.spec.ts (63.192 s)
PASS myapp7791666 apps/myapp7791666/src/app/+state/users.effects.spec.ts (64.325 s)
Test Suites: 1 failed, 3 passed, 4 total
Tests: 6 passed, 6 total
Snapshots: 0 total
Time: 66.031 s
Ran all test suites.
Test Suites: 1 failed, 1 skipped, 1 passed, 2 of 3 total
Tests: 1 failed, 7 skipped, 4 passed, 12 total
Snapshots: 0 total
Time: 267.49 s
Ran all test suites.
Hi @johannesschobel plan is to get this finished this week.
By reading the comments on https://github.com/nrwl/nx/issues/10117, I understood there were more stuff to fix than expected explaining the delay for this. I'm facing https://github.com/nrwl/nx/issues/10537 issue and I was wondering if you had a new ETA for this PR ?
@FrozenPandaz I'm a little confused. I see this PR is merged and I see that there has been an Nx release published since this merge; however, when I run nx migrate latest
and nx migrate --run-migrations
my jest version stays at 27. Shouldn't it be getting bumped to v28 now?
Same here. I also tried to migrate to 14.6.0-beta.0 or 14.6.0-beta, but persist at 27.
@jaytavares I found solution. You can try nx migrate 14.6.0-beta.7
@jaytavares @rique-dev this change is included in v14.6.0 which is in beta right now. if you want to migrate to the beta version you have to use the next
tag not latest.
if you want to jump to the beta you can use.
nx migrate @nrwl/jest@next --from @nrwl/[email protected]
if you were already on a beta then it probably didn't get bumped correctly since the PR targeted an earlier beta that was already released.
@barbados-clemens Awesome! Thx!
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.