sofie-mos-connection icon indicating copy to clipboard operation
sofie-mos-connection copied to clipboard

Published 20 hours ago • verified publisher icon nrkno

WIP: objId was parsed as a number, and thus removed e.g. 00

Open olzzon opened this issue 9 months ago • 0 comments

About the Contributor

This PR was made on behalf of BBC

Type of Contribution

Bug Fix for https://github.com/nrkno/sofie-mos-connection/issues/92

Current Behavior

If ObjID was a string that could be converted to a number (e.g. 00123.45600) all 00 around it would be removed.

New Behavior

In xml2Js there's now a Set called forcedStringObject where all object name in it will be forced to be converted as a string.

Testing Instructions

Create an obj with objID as a number, and ingest.

Helper Tests has also been updated for this.

Status

  • [ ] PR is ready to be reviewed.
  • [x] The functionality has been tested by the author.
  • [x] Relevant unit tests has been added / updated.
  • [x] Relevant documentation (code comments, system documentation) has been added / updated.

olzzon avatar May 06 '24 13:05 olzzon