sofie-core
sofie-core copied to clipboard
Tv2 sync release47
This PR contains a few of the latest changes from TV2/develop.
Co-authored by @LindvedKrvang and @jstarpl
Codecov Report
Base: 68.09% // Head: 69.59% // Increases project coverage by +1.49% :tada:
Coverage data is based on head (
7f61654) compared to base (ab0b3c1). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## release47 #780 +/- ##
=============================================
+ Coverage 68.09% 69.59% +1.49%
=============================================
Files 278 279 +1
Lines 34708 34934 +226
Branches 4639 5150 +511
=============================================
+ Hits 23636 24311 +675
+ Misses 10631 10181 -450
- Partials 441 442 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| meteor/lib/lib.ts | 70.05% <ø> (ø) |
|
| meteor/server/lib.ts | 45.16% <0.00%> (-8.69%) |
:arrow_down: |
| meteor/lib/api/pubsub.ts | 90.80% <0.00%> (-3.49%) |
:arrow_down: |
| packages/blueprints-integration/src/context.ts | 100.00% <0.00%> (ø) |
|
| packages/job-worker/src/playout/datastore.ts | 84.84% <0.00%> (ø) |
|
| packages/job-worker/src/events/handle.ts | 22.58% <0.00%> (+0.27%) |
:arrow_up: |
| packages/job-worker/src/ingest/lock.ts | 99.46% <0.00%> (+2.68%) |
:arrow_up: |
| meteor/server/security/studio.ts | 82.71% <0.00%> (+3.35%) |
:arrow_up: |
| packages/job-worker/src/ingest/mosDevice/diff.ts | 91.30% <0.00%> (+3.62%) |
:arrow_up: |
| packages/job-worker/src/ingest/commit.ts | 90.78% <0.00%> (+4.60%) |
:arrow_up: |
| ... and 6 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
One thing I am noticing is there is a lot of small bits of tidying done here, many of them styling things that we at nrk don't necessarily agree on. Some of the tidying is fine (we do the same). I am a little worried that this could introduce churn where someone at nrk might undo when making their own changes, and could result in many more merge conflicts. @gundelsby/@jstarpl something to be discussed?