sofie-core icon indicating copy to clipboard operation
sofie-core copied to clipboard

feat: allow part to be queued from onTake

Open ianshade opened this issue 5 months ago • 1 comments

About the Contributor

This pull request is posted on behalf of TV 2 Norge.

Type of Contribution

This is a:

Feature

Current Behavior

Not possible to queue a part from onTake()

New Behavior

Blueprints can queue a dynamic part during the onTake() callback. A queuePartAfterTake() method was added IOnTakeContext. Naming of the method is quite verbose, to make it clear that it queues the new part after the part currently being Taken. In the future there might be a need to add another method that e.g. queues a part instead of performing the Take.

Testing

  • [ ] I have added one or more unit tests for this PR
  • [ ] I have updated the relevant unit tests
  • [ ] No unit test changes are needed for this PR

Affected areas

This PR affects the playout logic, specifically what happens during a Take. It introduces a non-breaking addition to the Blueprints API.

Time Frame

Other Information

Status

  • [x] PR is ready to be reviewed.
  • [x] The functionality has been tested by the author.
  • [ ] Relevant unit tests has been added / updated.
  • [ ] Relevant documentation (code comments, system documentation) has been added / updated.

ianshade avatar Jul 24 '25 06:07 ianshade

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:x: Patch coverage is 76.86567% with 31 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/job-worker/src/playout/take.ts 68.88% 14 Missing :warning:
...job-worker/src/blueprints/context/OnTakeContext.ts 42.10% 11 Missing :warning:
.../job-worker/src/blueprints/context/adlibActions.ts 70.00% 6 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

codecov-commenter avatar Jul 24 '25 06:07 codecov-commenter