feat: Server-side notifications #1193

[Julusian]

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

This implements the RFC #1193

New Behavior

Various areas of the job-worker are now able to show notifiations to the user. This is done with the help of a new mongo collection. These are typically the result of the blueprints calling the existing userLog or similar methods, and are now finally being shown to the user. Additionally, some cases where a blueprint method failed is now showing error notifications. These are not expected to be 'helpful' to users, but indicate that something is wrong with the system that would otherwise only be visible due to incorrect output/behaviour.

In general, this shouldn't show anything new to users except in the above cases. Except the ab logic will now produce some errors when it fails to assign sessions to players.

Testing

• [x] I have added one or more unit tests for this PR
• [x] I have updated the relevant unit tests
• [ ] No unit test changes are needed for this PR

Affected areas

This PR affects the playout logic in general. This PR affects the ingest logic in general.

Time Frame

Other Information

This builds on #1295, and includes the changes from that.

Status

• [x] PR is ready to be reviewed.
• [x] The functionality has been tested by the author.
• [x] Relevant unit tests has been added / updated.
• [ ] Relevant documentation (code comments, system documentation) has been added / updated.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 77.91411% with 180 lines in your changes missing coverage. Please review.

Project coverage is 56.63%. Comparing base (dd5010a) to head (b628877). Report is 12 commits behind head on release52.

Files with missing lines	Patch %	Lines
meteor/server/publications/system.ts	0.00%	34 Missing :warning:
packages/job-worker/src/playout/setNext.ts	29.26%	29 Missing :warning:
...ackages/job-worker/src/playout/abPlayback/index.ts	21.21%	26 Missing :warning:
...ker/src/blueprints/context/ShowStyleUserContext.ts	8.69%	21 Missing :warning:
...src/ingest/model/implementation/IngestModelImpl.ts	53.84%	12 Missing :warning:
...c/playout/model/implementation/PlayoutModelImpl.ts	76.00%	12 Missing :warning:
...job-worker/src/ingest/syncChangesToPartInstance.ts	9.09%	10 Missing :warning:
packages/job-worker/src/playout/adlibAction.ts	90.69%	7 Missing and 1 partial :warning:
packages/job-worker/src/notifications/util.ts	46.15%	7 Missing :warning:
packages/job-worker/src/ingest/commit.ts	73.91%	6 Missing :warning:
... and 5 more

Additional details and impacted files

@@              Coverage Diff              @@
##           release52    #1303      +/-   ##
=============================================
+ Coverage      56.40%   56.63%   +0.23%     
=============================================
  Files            399      401       +2     
  Lines          70876    71550     +674     
  Branches        4493     4541      +48     
=============================================
+ Hits           39978    40525     +547     
- Misses         30767    30892     +125     
- Partials         131      133       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.