sofie-core icon indicating copy to clipboard operation
sofie-core copied to clipboard

feat: Override NRCS Data in Sofie (Backend implementation) #1121

Open Julusian opened this issue 1 year ago • 1 comments

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

New Behavior

This implements the backend portion of #1121, with a very minimal UI changes to be able to prove/test the functionality.

This is a very large and sprawling change, almost all part of the ingest flow have been affected, as the flow had to be altered to support the idea that any ingest change can change anything about the rundown.

The change should be non-breaking, and not noticable unless the new blueprint method proccessIngestData is implemented. A fallback implementation of this method is provided which is intended to provide identical behaviour as previous sofie versions.

Read the proposal in the RFC: https://github.com/nrkno/sofie-core/issues/1121#issuecomment-1938900388

Testing

  • [x] I have added one or more unit tests for this PR
  • [ ] I have updated the relevant unit tests
  • [ ] No unit test changes are needed for this PR

Unit tests have been added for many of the ingest jobs as part of this change, as part of testing them to ensure they operate as expected.

Affected areas

This PR affects the ingest logic in general.

Time Frame

Other Information

Status

  • [x] PR is ready to be reviewed.
  • [x] The functionality has been tested by the author.
  • [x] Relevant unit tests has been added / updated.
  • [ ] Relevant documentation (code comments, system documentation) has been added / updated.

Julusian avatar Oct 18 '24 12:10 Julusian