sofie-core icon indicating copy to clipboard operation
sofie-core copied to clipboard

fix: refactor Rundown orphaned property SOFIE-2963 #1210

Open Julusian opened this issue 1 year ago • 1 comments

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Code improvement

Current Behavior

There is an overlap in what the source and orphaned properties on Rundown describe.

New Behavior

The states of orphaned have been simplified to avoid this overlap.

I considered moving orphaned to be a property of the RundownSourceNrcs, but this proved complicated and messy to do

Testing

  • [ ] I have added one or more unit tests for this PR
  • [ ] I have updated the relevant unit tests
  • [x] No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • [x] PR is ready to be reviewed.
  • [ ] The functionality has been tested by the author.
  • [ ] Relevant unit tests has been added / updated.
  • [ ] Relevant documentation (code comments, system documentation) has been added / updated.

Julusian avatar Jun 27 '24 14:06 Julusian