sofie-core icon indicating copy to clipboard operation
sofie-core copied to clipboard

fix: hide create playlist drop box when dragging a rundown not in a multi-rundown playlist SOFIE-2462

Open Julusian opened this issue 1 year ago • 1 comments

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

In the rundown list page, when dragging a rundown which is not grouped in a playlist, a dropbox is shown to create it in a new playlist. This has no visible effect, as the rundown is moved into a non-grouped playlist, giving the same result as before.

New Behavior

When dragging a rundown which is alone in a flattened playlist, don't show the drop box

Testing

  • [ ] I have added one or more unit tests for this PR
  • [ ] I have updated the relevant unit tests
  • [x] No unit test changes are needed for this PR

Affected areas

This is a minor ui change

Other Information

Status

  • [x] PR is ready to be reviewed.
  • [x] The functionality has been tested by the author.
  • [ ] Relevant unit tests has been added / updated.
  • [ ] Relevant documentation (code comments, system documentation) has been added / updated.

Julusian avatar Apr 29 '24 13:04 Julusian

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.98%. Comparing base (580ff9e) to head (3ce5bac). Report is 14 commits behind head on release51.

Additional details and impacted files
@@              Coverage Diff              @@
##           release51    #1181      +/-   ##
=============================================
- Coverage      57.98%   57.98%   -0.01%     
=============================================
  Files            519      519              
  Lines          83770    83784      +14     
  Branches        3821     3078     -743     
=============================================
+ Hits           48577    48583       +6     
- Misses         35168    35196      +28     
+ Partials          25        5      -20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 29 '24 13:04 codecov[bot]