kantan.csv icon indicating copy to clipboard operation
kantan.csv copied to clipboard

Published 20 hours ago • verified publisher icon nrinaudo

[feat request] Publishing for Scala.js 1.0.0

Open exoego opened this issue 5 years ago • 4 comments

Thanks for creating awesome library.

Scala.js 1.0.0 was finally published on 2020-2-5. I wish I could use kantan.csv on Scala.js 1.0.0. (Currently I use kantan.csv on Scala.js 0.6.32)

I would like to open PR for cross-publishing (Scala.js 0.6 and 1.0) to kantan.csv. in Scala.js ecosystem, it is a common practice that having SCALAJS_VERSION environment variable to switch between Scala.js 0.6/1.0 for cross-publishing. One example: https://github.com/scala-js/scala-js-dom/blob/9e47c2050e1f26542f39bd7efc92715a0b5f7f2a/project/build.sbt#L1-L5

But I noticed that this repository does not directly depends on scala-js. Instead, dependency is managed in kantan.sbt: https://github.com/nrinaudo/kantan.sbt/blob/dc83a799f6ab7f4778a3e54c073f8a4acdc6e5e4/project/Versions.scala#L13

How should kantan.sbt updated for cross publishing ? I will attempt to open PR for that.

It is also fine for me if you do not intend to cross-publishing (support only Scala.js 1.0.0, and drop Scala.js 0.6).

exoego avatar Feb 06 '20 05:02 exoego

I'd be happy to support scala.js 1.0.0 (and drop support for 0.6, probably), but is that even published? I thought only RC versions were out and the 1.0.0 was still in the works?

I don't think I'll add support to RC versions. But as soon as a new "official" release is out, I'll fast-track releasing support for it since there's apparently an explicit need for it. I expect scala-steward to do most of the work anyway.

nrinaudo avatar Feb 06 '20 07:02 nrinaudo

After several days from 1.0.0-RC2, the version1.0.0 was published to Maven centeral. It is stitll not announced yet, but we can actually use 1.0.0. https://mvnrepository.com/artifact/org.scala-js/scalajs-library

exoego avatar Feb 06 '20 09:02 exoego

I wasn't aware of that, thanks. I'll get on it as soon as I find some time.

nrinaudo avatar Feb 06 '20 09:02 nrinaudo

Well, It's officially out now. I've started working on adapting the various libraries kantan.csv depends on (kantan.sbt for the build, kantan.codecs for the scaffolding), but there are still projects that need to support it: scalatest and imp, at the very least. I guess I'm stuck until that's done...

nrinaudo avatar Feb 07 '20 14:02 nrinaudo