microbit icon indicating copy to clipboard operation
microbit copied to clipboard

Published 20 hours ago • verified publisher icon nrf-rs

Fix ci by bumbing msrv to 1.61

Open caemor opened this issue 2 years ago • 4 comments

Fixed released an update and now requires rust 1.61 (https://crates.io/crates/fixed)

caemor avatar Jul 21 '22 17:07 caemor

Bah, bumping MSRV in a minor update is not great. 1.61 is pretty recent so I'm not totally convinced we want to make such a jump. Do we know what exactly is pulling in fixed?

therealprof avatar Jul 21 '22 18:07 therealprof

Its pulled by nrf52833-hal -> nrf-hal-common: https://github.com/nrf-rs/nrf-hal/blob/663008c033ad67263e4ac0c561d5d1fac28d7170/nrf-hal-common/Cargo.toml#L25

And its "only" used to get the temperature: https://github.com/nrf-rs/nrf-hal/blob/56e2752cf81879c683a7fa64b5d579704f1d2746/nrf-hal-common/src/temp.rs

caemor avatar Jul 21 '22 19:07 caemor

Hm, nrf-hal is not specifying a MSRV so they're likely not too bothered by this. I guess the two options we have are:

  1. Restricting the fixed version in this crate (since nrf-hal is just going for "'1.0.0' and compatible")
  2. Bumping the MSRV

therealprof avatar Jul 21 '22 21:07 therealprof

I'm fine either way but prefer bumping the msrv slightly to avoid adding the 'fixed' restriction :man_shrugging:

We could also release a 0.13.1, where we keep the old msrv and in the next 0.14 release/main branch (which most likely takes a while until we have enough stuff and should be a major release until we reach 1.0) remove the restriction and update our msrv.

caemor avatar Jul 22 '22 15:07 caemor