weasel
weasel copied to clipboard
Fixing Uncaught TypeError: Cannot read property 'autoReconnect' of null (and add deps.edn)
When we are trying to instantiate and goog.net.WebSocket object, it breaks with nil/null option.
So I pass false
when params are nil.
I also added deps.edn
to make it simpler to use :git
with a specific sha in deps.edn
I ran into the same error after upgrading some project dependencies for JDK 11 support, and the fix to WebSocket instantiation resolved the error for me. Looks like the other proposed fix should work as well, happy to test and roll another pull request for that if preferred.
I'm not familiar with the codebase, so I'm down with whatever people feel is best.