weasel icon indicating copy to clipboard operation
weasel copied to clipboard

Fixing Uncaught TypeError: Cannot read property 'autoReconnect' of null (and add deps.edn)

Open dupuchba opened this issue 4 years ago • 2 comments

When we are trying to instantiate and goog.net.WebSocket object, it breaks with nil/null option. So I pass false when params are nil.

I also added deps.edn to make it simpler to use :git with a specific sha in deps.edn

dupuchba avatar May 08 '20 09:05 dupuchba

I ran into the same error after upgrading some project dependencies for JDK 11 support, and the fix to WebSocket instantiation resolved the error for me. Looks like the other proposed fix should work as well, happy to test and roll another pull request for that if preferred.

ben-denham avatar Nov 23 '20 10:11 ben-denham

I'm not familiar with the codebase, so I'm down with whatever people feel is best.

bbatsov avatar Jun 01 '21 08:06 bbatsov