brouter-web icon indicating copy to clipboard operation
brouter-web copied to clipboard

Improve import of POIs and GeoJSON layers

Open gorgobacka opened this issue 2 years ago • 3 comments
trafficstars

Thanks for this great tool.

I'm wondering, if it is possible to import POIs? I would like to manage some POIs externally that does not fit into OpenStreetMap. E.g. maybe via uMap.

But I'm not sure how I would get them into brouter-web.

Maybe an import via Geojson would be suitable or maybe there are better services for this purpose that directly allow an import via the Custom Layer feature.

gorgobacka avatar Aug 14 '23 22:08 gorgobacka

Importing POIs via GeoJSON already works. Both dropping a file and importing via "Load > Load Tracks" are supported. In addition, since #727 it is possible to configure GeoJSON layers (including markers, which I just confirmed) by adding corresponding config files into the layers directory.

GeoJSON files can be created by exporting from BRouter-Web, https://geojson.io/ or any other compliant service.

What we could improve upon:

  • [ ] Change the wording of "Load Tracks" to include waypoints too.
  • [ ] Document that drag-and-drop works.
  • [ ] Do not show an "Error loading tracks: GeoJSON has no valid layers." message if a file only contains waypoints and is otherwise valid.
  • [ ] Support adding GeoJSON layers in the "Custom layers" dialog.
  • [ ] Check that colors, size, icons, names etc. work according to spec.

rkflx avatar Aug 17 '23 21:08 rkflx

@rkflx Thanks a lot for your response. The drag-and-drop works perfect. It's what I was looking for.

Should I close the issue or should it stay open for the improvements you were mentioning?

gorgobacka avatar Aug 28 '23 17:08 gorgobacka

Should I close the issue or should it stay open for the improvements you were mentioning?

That's a good question. Ideally we'd follow the "one task per issue" recommendation. On the other hand, here this might be too much micro-management.

I'd say keep it open and change the title to something like "Improve import of POIs and GeoJSON layers". Maybe @nrenner can also add a "good first issue" label, so it might get picked up by potential new contributors…

rkflx avatar Aug 28 '23 18:08 rkflx