achavi icon indicating copy to clipboard operation
achavi copied to clipboard

More detailed layers/filters

Open borazslo opened this issue 9 years ago • 2 comments

I suggest to separate the changes layer to a changes and a created layer.

I also suggest to draw a distinction between the two types of deleted. For deleted elements the <action> object has a <new> object. In that the <node> osm element has a visible marker. If the element is deleted from the osm database then visible="false". If the element is not delete, but the element does not match the adiff query at the second time then visible="true". (See more: Augmented_Diffs) I think it is important to know whether an osm element is absolutely deleted or only does not match my filter criterions. (This issue is probably related with the usage of?url=my_own_adiff_xml_results only.)

borazslo avatar Jan 16 '16 05:01 borazslo

Hm, the old and changes layers correspond to the old and new (before/after) in the diff and I guess I would like to keep especially the changes layer in the current way to be able to turn off all after objects with a single click to see the before state.

But I agree that additional filters (deleted/modified/created, ...) would be helpful, either as a nested tree checkboxes or as separate filters. But those would probably need to be implemented in a different way than to simply removing and adding layers.

Need to check the deleted types handling - I am aware of the issue, I guess Roland called these "out of scope". I guess only a warning in the popup is shown for such edge cases, but yes, special styling and probably filters would be helpful.

nrenner avatar Jan 18 '16 19:01 nrenner

Handling of out of scope objects is still an open task, but delete + visible="true" is already taken into account. It is assumed that the geometry was moved outside the requested bbox/area and therefore it is styled as old geometry (see legend) and a warning is shown in the popup.

I guess more information would be needed to detect and distinguish all cases (like retagged vs. moved outside bbox).

nrenner avatar Jan 22 '16 18:01 nrenner