Nolan Brubaker

I don't think the failure is related to this PR, nor the previous image issues we were seeing; the `AWSMachine` resources get to a `Ready` state and don't have errors...

/lgtm I think we should merge this and iterate on the docs. What do you think @vincepri and @richardcase? I know it's not the same as the upstream CAPI process,...

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/4748/pull-cluster-api-provider-aws-build-docker/1773297258993815552#1:build-log.txt%3A530 > make: *** No rule to make target 'release-binaries'. Stop. Could we rewrite this target to invoke goreleaser in a dry run that just builds the binaries instead?

@kranurag7 I made a [commit](https://github.com/nrb/cluster-api-provider-aws/commit/b9367fdfd1a21d84280bfe23b790305ad80e666a) which I believe will fix the CI job, as well as align what goreleaser produces more closely to the current contents of a release. This...

> If we intend to do it via goreleaser then the corresponding make targets needs to be adjusted accordingly. Pushed a commit that removes these targets, as well as removing...

/hold Holding because there are some missing artifacts when releasing with this configuration.

Updated code incoming, but I was able to successfully create a release with the custom release notes on my fork: https://github.com/nrb/cluster-api-provider-aws/releases/tag/v2.8.0 🎉

/unhold

/cherry-pick release-2.4 The `.goreleaser.yaml` file needs to be present in the branch when its checked out during the build. We worked around this for v2.4.2, but the cherry-pick will be...

@nikParasyr I think ✨ is fine