Noam Rathaus

Results 96 comments of Noam Rathaus

I can rebase it to `origin/main` if you wish - its currently rebased against `origin/dev` to make it easier

The problem lies here: ``` def detect_exposure(data: str) -> dict: # Dictionary to store detected data exposures detected_exposures = {} for pattern_name, pattern in sensitive_data_regex_patterns.items(): matches = findall(pattern, data) if...

Complete code: ``` def detect_exposure(data: str) -> dict: # Dictionary to store detected data exposures detected_exposures = {} for pattern_name, pattern in sensitive_data_regex_patterns.items(): matches = findall(pattern, data) if matches: if...

Please note my PR contains this fix if you want to merge it

I don't see in the PR any suggestion

You misunderstood me, today the way to know whether you are or not vulnerable is by `text` comparison, I suggest to just add a variable that says `vulnerable` to the...

I though `result` was whether the regex was successful or not, not necessarily that it is vulnerable I think the word `result` word should be changed to `vulnerable` as it...

Let me know if this is the intended tests you were looking for: https://github.com/OWASP/OFFAT/pull/111

I guess we can close this down as there is no interest

The idea is to find a file that exists, then see if .bak version of it exists - not to duplicate the number of files queried for by adding another...