ng-cordova-oauth icon indicating copy to clipboard operation
ng-cordova-oauth copied to clipboard

Published 20 hours ago • verified publisher icon nraboy

Yandex & Mail.ru services

Open mche opened this issue 8 years ago • 9 comments

Hi!

Push big russian Yandex and Mail.ru services.

mche avatar Oct 30 '16 08:10 mche

Just to confirm, since I am not familiar with this service. You've tested it and it works great with your PR?

Once you confirm it is working, I'll merge it.

Referencing https://github.com/nraboy/ng-cordova-oauth/pull/299

nraboy avatar Nov 03 '16 18:11 nraboy

Sorry for PR #299 there is incorrect response_type=code. Now works response_type=token.

Im recheck api and had tests works fine for this PR.

mche avatar Nov 04 '16 18:11 mche

Great job @mche I Like the code. 👍 If it's working and after some changes I think this PR can be merged. @mche Thanks for your contribution

matheusrocha89 avatar Nov 09 '16 18:11 matheusrocha89

Thanks @matheusrocha89

nraboy avatar Nov 10 '16 06:11 nraboy

Ok, I had inspected the recomendations.

mche avatar Nov 11 '16 11:11 mche

We ready to merge?

nraboy avatar Nov 12 '16 16:11 nraboy

Does my comments in README.md are clean? Or may be remove them?

mche avatar Nov 14 '16 05:11 mche

The comments for me are fine. I think you can remove the comments on the code and let them there on readme

matheusrocha89 avatar Nov 14 '16 14:11 matheusrocha89

@matheusrocha89 Im sorry but comments in code does needs like for me.

mche avatar Nov 15 '16 04:11 mche